fixup! chore: fix some issues pointed by the sonarcloud linter

viniciusferrao · Jul 31, 2024 · d7557d9 · d7557d9
1 parent ff02428
commit d7557d9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/include/cloysterhpc/messagebus.h b/include/cloysterhpc/messagebus.h
@@ -37,7 +37,7 @@ class MessageReply {
     }
 
     explicit MessageReply(std::any&& reply)
-        : m_base_reply(std::move(reply))
+        : m_base_reply(reply)
     {
     }
 
@@ -81,7 +81,10 @@ class MessageBusMethod {
     virtual MessageReply callMethod() = 0;
 
 public:
-    void addParams() { }
+    void addParams()
+    {
+        // end case for the variadic template below
+    }
 
     template <typename T, typename... Ts> void addParams(T param, Ts... params)
     {

diff --git a/include/testing/test_message_bus.h b/include/testing/test_message_bus.h
@@ -25,15 +25,14 @@ class TestMessageBus : public MessageBus {
 
     void registerCall(FunctionStore s, FunctionParameters p)
     {
-        auto count = this->callCount(s);
         m_functions[makeStoreName(s)].push_back(p);
     }
 
 public:
     std::unique_ptr<MessageBusMethod> method(
         std::string interface, std::string method);
 
-    void dump() const;
+    [[maybe_unused]] void dump() const;
 
     unsigned callCount(FunctionStore s) const;
     FunctionParameters calledWith(FunctionStore s, unsigned index) const;

diff --git a/test/test_message_bus.cpp b/test/test_message_bus.cpp
@@ -48,6 +48,6 @@ std::unique_ptr<MessageBusMethod> TestMessageBus::method(
 MessageReply TestMessageMethod::callMethod()
 {
     m_bus->registerCall(m_store, m_params);
-    return MessageReply(
-        std::make_any<sdbus::ObjectPath>(sdbus::ObjectPath("123")));
+    auto reply = std::make_any<sdbus::ObjectPath>(sdbus::ObjectPath("123"));
+    return MessageReply(std::move(reply));
 }