Update repos.h, add Rocky Linux support, create nodes operational system presenter #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
There was a problem hiding this comment.
@lbgracioso I've reviewed some of your changes but unfortunately there's things that I don't understood correctly and there's some suggestions. I made some suggestions and comments that we can discuss.
Thanks.
…const Signed-off-by: lbgracioso <[email protected]>
|
@viniciusferrao Please check the latest commit (27a91d5) . |
…h dry-run variable to old value Signed-off-by: lbgracioso <[email protected]>
lbgracioso
changed the title
viniciusferrao
approved these changes
May 25, 2023
Signed-off-by: Vinícius Ferrão <[email protected]>
|
Thanks @lbgracioso it's merged. The OS ISO selection section was very good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry about the amount of changed files but most of them have only small changes.
In this pull request I added the so expected support to Rocky Linux and also made few updates in the
repos.h.Edit: Create presenter to choose nodes operational system.