Integrate cryptopp and implement iso checksum verification #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lbgracioso <[email protected]>
There was a problem hiding this comment.
Hi @lbgracioso there's is some issues with this PR. But again, thanks for the PR, it's definitely a good idea.
…ut' lowercase instead of 'isoHash' Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
# Conflicts: # src/CMakeLists.txt # test/CMakeLists.txt
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: Vinícius Ferrão <[email protected]>
|
I've added a context with references to explicit why the So it has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
This was a fast one.
Integrating a new library,
cryptoppand implementing a checksum verification to disk images (only works if the disk image uses a known name, so if users try to use a custom image they won't have problems, unless they use a known name).