[CLOYSTER-96] Implement Postfix #26
Conversation
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: lbgracioso <[email protected]>
|
|
LGTM |
There was a problem hiding this comment.
The PR is good, however there's some details that should be addressed. I've made code suggestions where it makes sense.
However there's still open points on the templated use of main.cf and master.cf.
I don't see any tests also. It would be good if we have some. Mailsystem is not easily testable when implemented due to external connections and factors, so if we can do some tests in the code would easy future debugging.
There was a problem hiding this comment.
Let's get this PR moving.
Regarding the master file. I think it would be better to leave the master file as is. We can disable local delivery with this instead: https://serverfault.com/questions/582988/postfix-disabling-local-delivery-correctly
There was a problem hiding this comment.
Is there an easy list to see what is modified here?
It may be a wiser solution to just use postconf instead.
| smtp_tls_security_level = may | ||
| # meta_directory = /etc/postfix | ||
| # shlib_directory = /usr/lib64/postfix | ||
|
|
There was a problem hiding this comment.
I think from here we should use addStringToFile instead of templating the file. Why? Because it will avoid mixing changes from the distribution instead when Postfix is installed by dnf.
| ini.setValue("", "relayhost", | ||
| fmt::format("{}:{}", m_domain.value(), m_port.value())); | ||
| break; |
There was a problem hiding this comment.
Accordingly to Postfix documentation we have:
In the case of SMTP, specify a domain, host, host:port, [host]:port,
[address] or [address]:port; the form [host] turns off MX lookups.
I think is should also use the [] notation.
| ini.setValue("", "relayhost", | |
| fmt::format("{}:{}", m_domain.value(), m_port.value())); | |
| break; |
Signed-off-by: Vinícius Ferrão <[email protected]>
Signed-off-by: Vinícius Ferrão <[email protected]>
|
Hey!
This PR finishes the implementation of Postfix with answerfile.
postfix,postfix.relay,postfix.sasl)