Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EPEL 'Modular' for EL9 from getXCATOSImageRepos in repos.cpp #44

Merged

Conversation

lbgracioso
Copy link
Collaborator

EPEL 9 removed 'Modular' but kept 'Everything'.

The previous ones also have 'Everything', so we can use it by default.

@lbgracioso lbgracioso added the bug Something isn't working label Feb 22, 2024
Copy link
Owner

@viniciusferrao viniciusferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will remove the modular support for EL8 also. EL8 must still supports modular repositories, a version check should be done.

@lbgracioso lbgracioso changed the title Remove EPEL 'Modular' from getXCATOSImageRepos in repos.cpp Remove EPEL 'Modular' for EL9 from getXCATOSImageRepos in repos.cpp Feb 22, 2024
There's a small logic change to express intent. Modular repositories are only available on EL8. So it should be an equal comparison.

Signed-off-by: Vinícius Ferrão <[email protected]>
Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@viniciusferrao viniciusferrao merged commit fe81b27 into viniciusferrao:master Feb 25, 2024
1 of 2 checks passed
@lbgracioso lbgracioso deleted the remove-epelmodular-reposcpp branch February 26, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants