Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postscript for InfiniBand #45

Closed

Conversation

lbgracioso
Copy link
Collaborator

This PR is to fix issue #38

Run chdef compute -p postscripts=confignetwork to configure InfiniBand (if using it).

@lbgracioso lbgracioso added the enhancement New feature or request label Feb 23, 2024
@lbgracioso lbgracioso changed the title Add postscript for @infiniband Add postscript for InfiniBand Feb 23, 2024
Copy link
Owner

@viniciusferrao viniciusferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is not good.

It assumes that a group named compute exists and changes every system configuration that are already on the compute group.

That will not solve the issue and will add inconsistencies to the program.

  1. The software is unaware if IB exists or not, and even when it does not exist it will run the chdef command.

  2. In this stage of the software the will be nothing on the supposed compute group. So the command is irrelevant.

  3. Those modifications should be done in other place, we need to verify if xCAT supports adding that to the osimage instead. That would fix the issue for everything that will be added later.

  4. But also changing on the osimage is not trivial: we need to check in advance which images are available and make a decision after.

@lbgracioso
Copy link
Collaborator Author

It assumes that a group named compute exists and changes every system configuration that are already on the compute group.

  1. In this stage of the software the will be nothing on the supposed compute group. So the command is irrelevant.

We have a problem then, because other functions (for example, XCAT::resetNodes and XCAT::setNodesImage) use compute as default. If it doesn't exist, these functions are also broken. How we can fix that?

  1. The software is unaware if IB exists or not, and even when it does not exist it will run the chdef command.

XCAT::configureInfiniband should verify if it exists or not - and that should be a new issue, not related to this PR.

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lbgracioso lbgracioso closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants