Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to utilize a custom repository file #53

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

lbgracioso
Copy link
Collaborator

This pull request introduces the capability to utilize a custom repository file and it also eliminates the GPG keys creation (Instead, it now utilizes a URL for this purpose).

Please note that the URL may be subject to modification in the future.

@lbgracioso lbgracioso added the enhancement New feature or request label Apr 12, 2024
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@viniciusferrao
Copy link
Owner

@lbgracioso why did you remove the capability of local files? That would prevent offline installations. Is there any reason or any fallback method to keep the offline install working?

@lbgracioso
Copy link
Collaborator Author

There was no "offline install" working, even before. It was only creating the GPG Keys.

The offline installation was a plan but not on my focus right now, and the code was also pretty messy. It's an idea to the future.

@lbgracioso lbgracioso marked this pull request as draft June 10, 2024 12:16
Signed-off-by: Lucas Gracioso <[email protected]>
Signed-off-by: Lucas Gracioso <[email protected]>
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lbgracioso
Copy link
Collaborator Author

@viniciusferrao Please see 585aeea

Signed-off-by: Lucas Gracioso <[email protected]>
@lbgracioso lbgracioso marked this pull request as ready for review June 18, 2024 14:08
@viniciusferrao
Copy link
Owner

Thanks @lbgracioso

Theres some changes to do in the future but it's looks good.

@viniciusferrao viniciusferrao merged commit c7c3b28 into viniciusferrao:master Jun 18, 2024
1 check passed
@lbgracioso lbgracioso deleted the import_local_repos branch June 18, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants