Patch Mellanox OFED with mlnxofed-patch #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Gracioso <[email protected]>
|
|
I forgot to mention this before so I'll now. I put it under "throw" on purpose because OFED is not supported yet. |
|
I'm not sure this is a good implementation. Maybe the patch should be absorbed by the system but just "wgetting | bash" is not good, it does not add predicability and will eventually break. I don't know how to properly implement this addition but I know that's isn't the way. Perhaps we should host our own patched repository, so this would eventually became just a repo addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mlnxofed-patch to patch it.
Note
MLNX is not yet supported, but the patch is already available so we won't forget about it in the future.