Make log level configurable (#377) #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanheller
approved these changes
May 11, 2023
silvanheller
previously approved these changes
May 11, 2023
lucaro
requested changes
May 11, 2023
There was a problem hiding this comment.
The way this is implemented only makes sense under the assumption that cineast is the only application running in a particular environment, such as a docker container. In all other cases, it uses a generic environment variable without any context. To make this more generally applicable, I'd suggest calling the variable something like CINEAST_LOG_LEVEL, in case there are several applications in the same environment that use a similar mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
LOG_LEVELto configure log level. Default changed toINFO.