Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer backend #27

Merged
merged 7 commits into from
Mar 11, 2023
Merged

Safer backend #27

merged 7 commits into from
Mar 11, 2023

Conversation

vixalien
Copy link
Owner

@vixalien vixalien commented Mar 7, 2023

fixes #10

@sonnyp please review 😁️

@vixalien
Copy link
Owner Author

vixalien commented Mar 7, 2023

you can try and test if the app automatically picks up your old notes, then converts them into the new storage scheme seamlessy

Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #10 👍

Thanks!

src/store.ts Outdated Show resolved Hide resolved
src/view.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless I missed something - you should handle errors here so they're not silent

src/application.ts Outdated Show resolved Hide resolved
src/view.ts Outdated Show resolved Hide resolved
src/store.ts Outdated Show resolved Hide resolved
src/store.ts Outdated Show resolved Hide resolved
@vixalien vixalien merged commit 231b877 into main Mar 11, 2023
@vixalien vixalien deleted the safer-backend branch March 11, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safer backend
2 participants