Add chartjs 2.4 compatibility #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kdekooter Looks like @FilipeDominguesGit opened up a PR with the same solution. I mentioned I would merge that one over this one since I think it was his original solution from #7? @FilipeDominguesGit would you prefer for your PR to merged over this one? @kdekooter I'll still leave review comments. Looks like you re-created the PR. |
|
@sedouard Dont really mind wich one you pick. 😄 Was a team effort so whatever works for you guys its fine by me. |
|
@sedouard Sorry I missed the other PR. I don't mind you picking the competing one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed errors around HTMLCanvasElement and CanvasRenderingContext2D that popped up when using chartjs 2.4 - see issue #7. Thanks go to @FilipeDominguesGit for being the first with a working solution.