Added method to return data url #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedouard
reviewed
Jan 3, 2017
| * @param {String} imageType The image type name. Valid values are image/png image/jpeg | ||
| * @returns {Promise} A promise that resolves when the image is received in the form of data url | ||
| */ | ||
| getImageDataUrl(imageType) { |
There was a problem hiding this comment.
NIT: Tab this back to line up with the other methods.
|
Thanks @akhilrex! This looks awesome 👍 . Just one tiny formatting issue. If you can just fix it real quick I'll have it merged and published today. Cheers! 🍻 |
|
Done!! |
|
Thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I have added a simple method that returns the data url that can be returned directly in the img tag. It just exposes the default functionality of canvas.