Skip to content

Commit

Permalink
Address feedback.
Browse files Browse the repository at this point in the history
Signed-off-by: Andon Andonov <[email protected]>
  • Loading branch information
doks5 committed May 17, 2023
1 parent 45047d2 commit f7c68d0
Showing 1 changed file with 1 addition and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ private void updateCronJob(DataJob dataJob, JobDeployment jobDeployment, String
"-c",
"cp -r $(python -c \"from distutils.sysconfig import get_python_lib;"
+ " print(get_python_lib())\") /vdk/. && cp /usr/local/bin/vdk /vdk/.");
var jobVdkImage = getJobVdkImage(jobDeployment);
var jobVdkImage = supportedPythonVersions.getVdkImage(jobDeployment.getPythonVersion());
var jobInitContainer =
KubernetesService.container(
"vdk",
Expand Down Expand Up @@ -306,18 +306,6 @@ private void updateCronJob(DataJob dataJob, JobDeployment jobDeployment, String
}
}

private String getJobVdkImage(JobDeployment jobDeployment) {
if (!supportedPythonVersions.getSupportedPythonVersions().isEmpty()
&& supportedPythonVersions.isPythonVersionSupported(jobDeployment.getPythonVersion())) {
return supportedPythonVersions.getVdkImage(jobDeployment.getPythonVersion());
} else {
log.warn(
"An issue with the job deployment's pythonVersion or supportedPythonVersions"
+ " configuration has occurred. Returning default vdk image");
return supportedPythonVersions.getDefaultVdkImage();
}
}

/**
* Returns the environment variables set to vdk that are based on job configuration. Those are
* automatically injected during cloud runs
Expand Down

0 comments on commit f7c68d0

Please sign in to comment.