vdk-lineage: support for latest version sqllineage library #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latest version of sqllineage is moreving `statements_parsed` method We are adopting our vdk-lineage plugin to support the latest release. This means we won't detect query type but that property was never used anywhere by vdk-lineage. Testing Done: existing unit tests Signed-off-by: Antoni Ivanov <[email protected]>
DeltaMichael
reviewed
Apr 3, 2023
projects/vdk-plugins/vdk-lineage/src/vdk/plugin/lineage/sql_lineage_parser.py
Show resolved
Hide resolved
DeltaMichael
approved these changes
Apr 3, 2023
gageorgiev
approved these changes
Apr 3, 2023
yonitoo
pushed a commit
that referenced
this pull request
Apr 4, 2023
latest version of sqllineage is removing `statements_parsed` method We are adopting our vdk-lineage plugin to support the latest release. This means we won't detect query type but that property was never used anywhere by vdk-lineage. Caught by nightly build tests https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/4043903802 Testing Done: existing unit tests Signed-off-by: Antoni Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latest version of sqllineage is removing
statements_parsedmethod We are adopting our vdk-lineage plugin to support the latest release. This means we won't detect query type but that property was never used anywhere by vdk-lineage.Caught by nightly build tests https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/4043903802
Testing Done: existing unit tests