vdk-control-cli: use common output printer #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/vdk-control-cli-adopt
branch
from
5846dc6
to
517314b
Compare
DeltaMichael
reviewed
Apr 6, 2023
projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/deploy_cli_impl.py
Outdated
Show resolved
Hide resolved
DeltaMichael
reviewed
Apr 6, 2023
projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/deploy_cli_impl.py
Outdated
Show resolved
Hide resolved
DeltaMichael
approved these changes
Apr 6, 2023
yonitoo
approved these changes
Apr 6, 2023
Adopting the new output_printer to print all outputs of all commands Some commands required small refactoring - to make some fields private. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/vdk-control-cli-adopt
branch
from
517314b
to
b5fe18e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopting the new output_printer to print all outputs of all commands that were introduced in #1819
Some commands required small refactoring - to make some fields private.
Testing Done: existing tests to verify no regressions