frontend: remove unused config in helm chart for frontend dns #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
murphp15
changed the title
murphp15
changed the title
duyguHsnHsn
approved these changes
Apr 20, 2023
DeltaMichael
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Config that was copied from the private VMWare helm charts has no purpose in the public helm chart.
How
Here is a good blog that describes what the properties I am removing do:
https://blog.knoldus.com/introduction-to-external-dns-in-kubernetes/
As you can see they are only used if you have registered and externalDns which we have not.
So I am removing them to keep the code clean.
How has this been tested?
Locally