control-service: Expose supported python versions in helm #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/expose-in-helm
branch
2 times, most recently
from
03f340a
to
7f7161b
Compare
gageorgiev
approved these changes
Apr 24, 2023
|
When are you planning to deprecate the old properties? |
mivanov1988
reviewed
Apr 24, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/expose-in-helm
branch
from
7f7161b
to
d982bae
Compare
I was thinking of doing it in a separate PR, but I guess it wouldn't make much of a difference if it happens in this one. |
doks5
force-pushed
the
person/andonova/expose-in-helm
branch
4 times, most recently
from
f560e22
to
230c12d
Compare
mivanov1988
approved these changes
Apr 25, 2023
doks5
force-pushed
the
person/andonova/expose-in-helm
branch
from
230c12d
to
2628ca2
Compare
As part of the initiative to support multiple python versions in data job deployments, new configurations were introduced in the form of `datajobs.deployment.supportedPythonVersions` and `datajobs.deployment.defaultPythonVersion` configuration properties. To facilitate proper production setup of the Control Service with the new functionality, the configuration needs to be exposed in the helm chart. This change updates the values.yaml and deployment.yaml files of the Control Service helm chart to expose the supportedPythonVersions and defaultPythonVersion configurations and set them as environment variables. Testing Done: CI/CD and local run of `helm lint` on the chart. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/expose-in-helm
branch
from
2628ca2
to
213f204
Compare
doks5
added a commit
that referenced
this pull request
May 29, 2023
As part of the initiative to support multiple python versions for data job deployments, we introduced new configurations through the `datajobs.deployment.supportedPythonVersions` and `datajobs.deployment.defaultPythonVersion` properties. This new configuration renders the old configurations through `datajobs.vdk.image` and `datajobs.deployment.dataJobBaseImage` essentially useless, as these are no longer used. This change cleans up the old configurations and related code and tests, so that only the new configurations remain. A more descriptive list of the changes is as follows: * The `DOCKER_VDK_BASE_IMAGE` and `DATAJOBS_DEPLOYMENT_DATAJOBBASEIMAGE` environment variables are removed, as they are not needed anymore. * The templates associated with the above-mentioned env vars, projects/control-service/projects/helm_charts/pipelines-control-service/templates/_helpers.tpl, is also removed. * The JobImageDeployer, projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java, logic related to the stand-alone vdk image configuration is also cleaned up to use only the `supportedPythonVersions` functionality. Tests associated with the cleaned up logic are also removed. The new configurations were introduced in #2022 and #1935 Testing Done: CI/CD --------- Signed-off-by: Andon Andonov <[email protected]> Co-authored-by: github-actions <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the initiative to support multiple python versions in data job deployments, new configurations were introduced in the form of
datajobs.deployment.supportedPythonVersionsanddatajobs.deployment.defaultPythonVersionconfiguration properties.To facilitate proper production setup of the Control Service with the new functionality, the configuration needs to be exposed in the helm chart.
This change updates the values.yaml and deployment.yaml files of the Control Service helm chart to expose the supportedPythonVersions and defaultPythonVersion configurations and set them as environment variables.
Testing Done: CI/CD and local run of
helm linton the chart.