-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control-service: fix python api release #1946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publish a new version of the python client library - 1.0.7 - to expose supported python versions api Signed-off-by: Dako Dakov <[email protected]>
Dummy to re-trigger pipeline Signed-off-by: Dako Dakov <[email protected]>
The integration tests are run from commits on many irrelevant files. This is first step in removing some of those irrelenat triggers. Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
dakodakov
approved these changes
Apr 24, 2023
ivakoleva
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for looking into this.
Signed-off-by: murphp15 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We are failing to build the python api client in the main branch.
There are two issues.
The first is that we are trying to install python using apk.
This is not needed and is causing errors.
Also we are running out of memory generating the api client.
Upgrading to the latest version of the dependency has fixed this.
I was also able to delete .mustache files that we needed in our repo as a workaround to issues from using an older version of openapi-generator.
How has this been tested.
Tested manually by making a commit where the client is built for any change.
Also integration tests