Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control-service: Clean up old data job configurations #2075

Merged
merged 3 commits into from
May 29, 2023
Merged

control-service: Clean up old data job configurations #2075

merged 3 commits into from
May 29, 2023

Commits on May 29, 2023

  1. control-service: Clean up old data job configurations 

    As part of the initiative to support multiple python versions for data job
deployments, we introduced new configurations through the `datajobs.deployment.supportedPythonVersions`
and `datajobs.deployment.defaultPythonVersion` properties.
This new configuration renders the old configurations through `datajobs.vdk.image` and
`datajobs.deployment.dataJobBaseImage` essentially useless, as these are no longer used.

This change cleans up the old configurations and related code and tests, so that only
the new configurations remain.

Testing Done: CI/CD

Signed-off-by: Andon Andonov <[email protected]>
    @doks5
    doks5 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    dbe280f View commit details
    Browse the repository at this point in the history

  2. Google Java Format

    @doks5
    github-actions authored and doks5 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    a7c18be View commit details
    Browse the repository at this point in the history

  3. Address feedback. 

    Signed-off-by: Andon Andonov <[email protected]>
    @doks5
    doks5 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    7f5e906 View commit details
    Browse the repository at this point in the history