-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] fix: d3 upgrade breaking change #125
Conversation
@vn7n24fzkq When you are free, can you give me a review? 😄 |
I am just checking the preview page.
Maybe we need to modify all of CJS import usage to EMS? |
Thanks for shareing 😄 I'll continue to try this problem, but we might to merge #124 to get the repository in the right state :) |
Sure, we can merge #124 first. I usually use I will make a development document soon. |
Thank you 😄 |
Sorry 🙏 🙏 🙏 |
No need to apologize, I completely understand that sometimes life can get busy and priorities can shift. It's important to manage your time and focus on what matters most to you. If you ever have the time in the future and still wish to do the PR, you can always revisit it at a later time. Take care and don't hesitate to reach out if you need any further assistance! And thanks for your contributions again!! |
d3
became pure ES modules form 7.0.ref: https://github.com/d3/d3/blob/main/CHANGES.md#changes-in-d3-70
I changed TypeScript output format from CommonJS to EMS.
I've seen that it works in my local environment.
ref: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
ref: https://www.typescriptlang.org/docs/handbook/esm-node.html
Sorry if you prefer CommonJS 🙏
Related: #124 #109