embed.FS broken on Windows

[shemanaev]

Summary

Go uses forward slashes for embed.FS even on Windows builds and loader can't find files with names made with filepath.Join.

Relevant issues: golang/go#45230, golang/go#44305

Steps to reproduce

Move locale/es.po to locale/es/helloworld.po in example.

Expected behavior

Load locales.

Observed behavior (that appears unintentional)

It doesn't load 😄.

[vorlif]

Hi @shemanaev,

Thanks for bringing up this point and for your research!

I'll have to have a look at how best to solve the problem while remaining compatible with the normal and embedded filesystem.

As a temporary fix, you could use a custom revolver with path.Join.

fsLoader, errFS := spreak.NewFilesystemLoader(
	spreak.WithResolver(&yourResolver{}),
	spreak.WithFs(yourFs),
)

[vorlif]

That took longer than it should have. Unfortunately, there is no way to determine if it is an embedded filesystem. But according to the fs documentation, slashes should be used as path separators for fs.FS implementations anyway.

However, I have now created a new release, with which it should also work under Windows. Thanks for your report.

[shemanaev]

Everything works perfect now. Thank you! 👍