Initial stab at issue/1 #2
Conversation
|
Changes Unknown when pulling 8910f03 on jcpunk:issue-1 into * on hercules-team:master*. |
|
Changes Unknown when pulling 8910f03 on jcpunk:issue-1 into * on hercules-team:master*. |
|
Changes Unknown when pulling 8910f03 on jcpunk:issue-1 into * on hercules-team:master*. |
| identity = lambda { |x| x } | ||
| [ | ||
| [ | ||
| /^((\S+)\s+of\s+(.+))$/, |
There was a problem hiding this comment.
Not that I'm right... but looking over in ap_postgresql it seems like maybe you could take a different approach here?
Is namevar needed? or just that thigns that make it up.
There was a problem hiding this comment.
My ruby is "super bad". I've never learned the language and am mostly programming by pattern.
It looks like I'm doing similar things to what the pg_hba type is doing....
Alas namevar was created so I didn't have to change the other code. Puppet was treating ':name' as the namevar and when splitting the complex name into attribs the use of the directive name as ':name' was causing duplicate resource definitions.
|
Changes Unknown when pulling 3f15a6c on jcpunk:issue-1 into * on hercules-team:master*. |
|
Changes Unknown when pulling db10bd7 on jcpunk:issue-1 into * on hercules-team:master*. |
| @@ -26,6 +26,14 @@ def insync?(is) | |||
| end | |||
| end | |||
|
|
|||
| newparam(:namevar) do | |||
There was a problem hiding this comment.
I'd rather user name than namevar for that.
I know this might change the behavior, so I'd suggest something like this:
- use
:nameas the default namevar - add a
:directiveparameter for the directive name - feed both
:nameand:directiveinself.title_patternswith respectively the full match and the directive only - have
:directivedefault toself[:name]for compatibility purposes
This should make it backwards-compatible, and provider a nicer interface imo.
|
Changes Unknown when pulling 3008981 on jcpunk:issue-1 into * on hercules-team:master*. |
| @@ -89,6 +95,7 @@ Type documentation can be generated with `puppet doc -r type` or viewed on the | |||
|
|
|||
| The `SetEnv` directive is not unique per scope: the first arg identifies the entry we want to update, and needs to be taken into account. For this reason, we set `args_params` to `1`. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
That newline seems to have been added by mistake.
|
Changes Unknown when pulling ac2fda2 on jcpunk:issue-1 into * on hercules-team:master*. |
|
Dear @jcpunk, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Dear @jcpunk, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Odds are this needs some work, but I think I got the basics working