Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes querystring problem #372

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vwraposo
Copy link
Contributor

What problem is this solving?

Currently the Redirects UI adds the redirect querystring to the URL, but the navigate function changes the order of the querystring parameters, making the form redirect query to return null instead of the correct redirect.

This PR creates a solution to keep the redirect querystring in the same order for the query to be correct.

How should this be manually tested?

You can enter muji's redirect admin and click on the first redirect, in master the form is not shown but in the following workspace it should:

Workspace

Screenshots or example usage

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 19, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Feb 19, 2021

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

@juaresba juaresba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants