Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cache-store on routes listing #396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update cache-store on routes listing #396

wants to merge 2 commits into from

Conversation

vitorflg
Copy link
Contributor

@vitorflg vitorflg commented Jun 9, 2021 •
edited
Loading

What problem is this solving?

When an app route is edited and there isn't a user route for the specific binding, a new one is created.

The idea here is to update the cache-store, replacing the default app route with the user route created.

How should this be manually tested?

Workspace

Screenshots or example usage

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

Depends on pages-graphql

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 9, 2021 •
edited by vitorflg
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jun 9, 2021 •
edited by vitorflg
Loading

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@vitorflg vitorflg changed the title Fix: Update routes listing when a binding user route is created from … Update routes listing when a binding user route is created Jun 9, 2021
@vitorflg vitorflg self-assigned this Jun 9, 2021
@vitorflg vitorflg added the bug Something isn't working label Jun 9, 2021
vwraposo
vwraposo approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@vwraposo vwraposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just missing the changelog

@vitorflg vitorflg changed the title Update routes listing when a binding user route is created Update the routes listing store after a app route is edited Jun 9, 2021
@vitorflg vitorflg changed the title Update the routes listing store after a app route is edited Update the routes listing cache-store after a app route is edited Jun 9, 2021
@vitorflg vitorflg changed the title Update the routes listing cache-store after a app route is edited Update the routes listing cache-store after editing a route Jun 9, 2021
@vitorflg vitorflg changed the title Update the routes listing cache-store after editing a route Handle a new case on the routes listing cache-store update Jun 9, 2021
@vitorflg vitorflg changed the title Handle a new case on the routes listing cache-store update Handle a new case on a routes cache-store update Jun 9, 2021
@vitorflg vitorflg changed the title Handle a new case on a routes cache-store update Handle a new case in a routes cache-store update Jul 6, 2021
@vitorflg vitorflg changed the title Handle a new case in a routes cache-store update Update cache-store on routes listing Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vwraposo vwraposo vwraposo approved these changes

Assignees

@vitorflg vitorflg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitorflg @vwraposo