Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ add new prop to noOptions and set up translations #450

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

natanfernandes
Copy link

@natanfernandes natanfernandes commented May 18, 2023

What problem is this solving?

Add new prop to conditions component in order to translate the empty message

How should this be manually tested?

Workspace

Screenshots or example usage

Captura de Tela 2023-05-18 às 19 08 40

Type of changes

✔️ Type of Change
_ Bug fix
✔️ New feature
_ Breaking change
_ Technical improvements

Notes

How does this PR make you feel? 🔗

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented May 18, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented May 18, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@natanfernandes natanfernandes changed the title feat: add new prop and set up translations Feat/ add new prop to noOptions and set up translations May 23, 2023
Copy link

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only forgot to log the changes to CHANGELOG.md.

Once that's done, it looks good to me!


Reminder: it depends on vtex/styleguide#1441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants