Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing newsletter option to the correct place #602

Merged
merged 4 commits into from
Apr 18, 2022

Conversation

andreaugusto
Copy link
Contributor

What problem is this solving?

This PR writes the newsletter option in the correct place

How to test it?

Use this Workspace and toggle your newsletter preference.
It will be saving in your purchase info in the new Profile System. Link for the Profile System query if you don't belive me in link 1 (you got to find out your user id in it to get it. See link 2. More trouble then it's worth it, I know...)

Link 1: Fetching purchase info -> GET https://portal.vtexcommercestable.com.br/api/storage/profile-system/profiles//purchase-info?an=qastoreeu
Link 2: Fetching your user profile -> GET https://portal.vtexcommercestable.com.br/api/storage/profile-system/profiles//?an=qastoreeu&alternativeKey=email

@andreaugusto andreaugusto requested a review from a team as a code owner April 13, 2022 14:21
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Apr 13, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Apr 13, 2022

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@arthurepc
Copy link
Contributor

Don't forget to add a changelog entry 👁️‍🗨️

Copy link
Contributor

@arthurepc arthurepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎖️

@andreaugusto andreaugusto merged commit 5437210 into master Apr 18, 2022
@andreaugusto andreaugusto deleted the feat/writing-newsletter-option branch April 18, 2022 19:26
@vtex-io-docs-bot
Copy link

Beep boop 🤖 That's ok, I created an issue for this so we don't forget

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Apr 18, 2022

Your PR has been merged! App is being published. 🚀
Version 2.151.0 → 2.152.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants