Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chrome debugger be opt-in instead of default #1190

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pedro823
Copy link
Member

What is the purpose of this pull request?

To make the chrome debugger tunnel be an explicit opt-in instead of a default open port.

What problem is this solving?

This wastes resources on our cloud if the user is not actively using it. This allows us to intentionally measure the usage of this feature.

How should this be manually tested?

Try linking an app normally and see that it doesn't start the chrome debugger server. By using --with-debugger in your linking flow, the previous behavior is restored.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Chores checklist

  • Update CHANGELOG.md

Copy link

@fabianaferreira fabianaferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants