Skip to content

Commit

Permalink
perf(templateRef): avoid double render when using template ref on v-for
Browse files Browse the repository at this point in the history
close #9908
  • Loading branch information
yyx990803 committed Jan 18, 2024
1 parent c3087ff commit de4d2e2
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions packages/runtime-core/src/rendererTemplateRef.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,10 @@ export function setRef(
} else {
const _isString = isString(ref)
const _isRef = isRef(ref)
const isVFor = rawRef.f
if (_isString || _isRef) {
const doSet = () => {
if (rawRef.f) {
if (isVFor) {
const existing = _isString
? hasOwn(setupState, ref)
? setupState[ref]
Expand Down Expand Up @@ -118,14 +119,15 @@ export function setRef(
warn('Invalid template ref type:', ref, `(${typeof ref})`)
}
}
if (value) {
// #1789: for non-null values, set them after render
// null values means this is unmount and it should not overwrite another
// ref with the same key
// #9908 ref on v-for mutates the same array for both mount and unmount
// and should be done together
if (isUnmount || isVFor) {
doSet()
} else {
// #1789: set new refs in a post job so that they don't get overwritten
// by unmounting ones.
;(doSet as SchedulerJob).id = -1
queuePostRenderEffect(doSet, parentSuspense)
} else {
doSet()
}
} else if (__DEV__) {
warn('Invalid template ref type:', ref, `(${typeof ref})`)
Expand Down

0 comments on commit de4d2e2

Please sign in to comment.