Skip to content

Commit

Permalink
fix: always transpile syntaxes introduced in ES2020 or later
Browse files Browse the repository at this point in the history
To fix compatibility issues with webpack 4 and ESLint 6.

Browserslist doesn't support ES version queries, so we approximate it
as Chrome 79.0.0 and Node.js 12

Fixes #7209
  • Loading branch information
haoqunjiang committed Jun 27, 2022
1 parent 5b57792 commit c7fa1cf
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion packages/@vue/babel-preset-app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,21 @@ module.exports = (context, options = {}) => {

// resolve targets for preset-env
let targets = getTargets(rawTargets, { ignoreBrowserslistConfig, configPath })

// Webpack 4 uses acorn 6 underlyingly;
// The highest ESLint version that Vue CLI v4 supports is 6.x;
// Both can only parse ES2019 syntax + BigInt at most.
// Thus, newer syntaxes such as optional chaining and nullish coalescing won't
// be accept by webpack / ESLint, and must be processed by Babel first.
// Chrome 79 is the last Chrome version that doesn't support these syntaxes.
// So the targets set by the user cannot be higher than Chrome 79.
if (!targets.chrome || semver.gt(targets.chrome, '79.0.0')) {
targets.chrome = '79.0.0'
}

if (process.env.VUE_CLI_BABEL_TARGET_NODE) {
// running tests in Node.js
targets = { node: 'current' }
targets = { node: '12' }
} else if (process.env.VUE_CLI_BUILD_TARGET === 'wc' || process.env.VUE_CLI_BUILD_TARGET === 'wc-async') {
// targeting browsers that at least support ES2015 classes
targets = getWCTargets(targets)
Expand Down

0 comments on commit c7fa1cf

Please sign in to comment.