Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-service): Support webpack5 devServer.server configuration #7024

Closed
wants to merge 3 commits into from

Conversation

citrusjunoss
Copy link

@citrusjunoss citrusjunoss commented Mar 4, 2022

options 'https' is deprecated in favor of the devServer.server option.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

options 'https' is deprecated in favor of the devServer.server option.
@citrusjunoss citrusjunoss changed the title feat(cli-server): Support webpack5 devServer.server configuration feat(cli-service): Support webpack5 devServer.server configuration Mar 4, 2022
Copy link

@yutent yutent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改漏了一处, 要把 https: useHttps,干掉

@Shujee
Copy link

Shujee commented Jul 9, 2022

@yutent: Trying to understand. Is this commit deployed now? Can I do npm update or something to get this on my machine?

@yutent
Copy link

yutent commented Jul 10, 2022

@yutent: Trying to understand. Is this commit deployed now? Can I do npm update or something to get this on my machine?

I didn't follow it anymore, I fixed it locally myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants