Skip to content

Commit

Permalink
fix(VTextField): prevent tabbing to clear button
Browse files Browse the repository at this point in the history
fixes #11202
  • Loading branch information
KaelWD committed Aug 10, 2022
1 parent 170c7d1 commit f8ee680
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ exports[`VFileInput.ts should display file size 1`] = `
<div class="v-input__icon v-input__icon--clear">
<button type="button"
aria-label="clear icon"
tabindex="-1"
class="v-icon notranslate v-icon--link material-icons theme--light"
>
$clear
Expand Down Expand Up @@ -107,6 +108,7 @@ exports[`VFileInput.ts should display file size 2`] = `
<div class="v-input__icon v-input__icon--clear">
<button type="button"
aria-label="clear icon"
tabindex="-1"
class="v-icon notranslate v-icon--link material-icons theme--light"
>
$clear
Expand Down Expand Up @@ -153,6 +155,7 @@ exports[`VFileInput.ts should display total size in counter 1`] = `
<div class="v-input__icon v-input__icon--clear">
<button type="button"
aria-label="clear icon"
tabindex="-1"
class="v-icon notranslate v-icon--link material-icons theme--light"
>
$clear
Expand Down Expand Up @@ -202,6 +205,7 @@ exports[`VFileInput.ts should display total size in counter 2`] = `
<div class="v-input__icon v-input__icon--clear">
<button type="button"
aria-label="clear icon"
tabindex="-1"
class="v-icon notranslate v-icon--link material-icons theme--light"
>
$clear
Expand Down Expand Up @@ -294,6 +298,7 @@ exports[`VFileInput.ts should render chips 1`] = `
<div class="v-input__icon v-input__icon--clear">
<button type="button"
aria-label="clear icon"
tabindex="-1"
class="v-icon notranslate v-icon--link material-icons theme--light"
>
$clear
Expand Down Expand Up @@ -340,6 +345,7 @@ exports[`VFileInput.ts should render counter 1`] = `
<div class="v-input__icon v-input__icon--clear">
<button type="button"
aria-label="clear icon"
tabindex="-1"
class="v-icon notranslate v-icon--link material-icons theme--light"
>
$clear
Expand Down Expand Up @@ -433,6 +439,7 @@ exports[`VFileInput.ts should render small chips 1`] = `
<div class="v-input__icon v-input__icon--clear">
<button type="button"
aria-label="clear icon"
tabindex="-1"
class="v-icon notranslate v-icon--link material-icons theme--light"
>
$clear
Expand Down
1 change: 1 addition & 0 deletions packages/vuetify/src/components/VInput/VInput.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ export default baseMixins.extend<options>().extend({
dark: this.dark,
disabled: this.isDisabled,
light: this.light,
tabindex: type === 'clear' ? -1 : undefined,
},
on: !hasListener
? undefined
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ exports[`VSelect.ts should be clearable with prop, dirty and multi select 1`] =
<div class="v-input__icon v-input__icon--clear">
<button type="button"
aria-label="clear icon"
tabindex="-1"
class="v-icon notranslate v-icon--link material-icons theme--light"
>
$clear
Expand Down Expand Up @@ -85,6 +86,7 @@ exports[`VSelect.ts should be clearable with prop, dirty and single select 1`] =
<div class="v-input__icon v-input__icon--clear">
<button type="button"
aria-label="clear icon"
tabindex="-1"
class="v-icon notranslate v-icon--link material-icons theme--light"
>
$clear
Expand Down

0 comments on commit f8ee680

Please sign in to comment.