-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cropTo() to fail due to resource limitation #54
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Jan-Ivar Bruaroey <[email protected]>
|
Here are some thoughts that have been shared during this editor's call:
With regards to 4 (the most interesting part of the discussion), some more thoughts, either shared during the call or not:
|
I believe @dontcallmedom and @aboba are working on clarifying rules of engagement in github issues for our WG. We have an interim meeting on Tuesday, so I'm going to focus on slides for #17. I encourage others to contribute slides on that issue as well. To me, the agenda looks light, so maybe there would be time to present this issue as well if you wish to prepare slides? |
Thanks. I've made that change.
Then I have misunderstood you during the meeting. Apologies for misrepresenting your position here.
I don't think we rushed anything yet.
Probably not.
Let's.
I am not sure, but hopefully people more experienced than me would know.
I see it as intentionally general, covering any implementation-specific limitation that prevents a browser from changing cropping at a given time. It gives developers predictability and interoperability in detecting otherwise-unexpected errors, without requiring us to discuss every newly-discovered implementation issue we encounter in the future. (If certain errors do become interesting enough to merit special treatment, we can specify later that these specific issues get handled differently.)
Maybe. Wdyt? Should we?
Even if it's not a big deal, specifying it seems better than leaving it unspecified. See more below.
If other implementations run into their own set of idiosyncratic limitations, they will be glad to discover that there is a predictable way of failing, and that developers are already aware of that type of failure. When the spec is aligned with implementations, everyone benefits.
That's great. Please let me know if there's anything in the engagement around this issue thus far, that you think could be improved.
I am not sure I'll be able to attend. I regret that the intention to discuss #17 was announced only today, or I would have cleared my schedule ahead of time. (As of earlier today, no agenda items were announced.) I'll try to shuffle around my other commitments and make it. But if I cannot, I suggest that it might be more productive to discuss Region Capture during an interim meeting which I can attend. For your consideration. |
<li> | ||
If the user agent is unable to change the [=crop-state=] of the | ||
{{MediaStreamTrack}}, for example due to resource limitation, the user agent MUST | ||
return a new {{Promise}}, [=rejected=] with an {{OperationError}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(editorial) shouldn't we say "reject p and return it", given that it was created before the parallel steps?
Preview | Diff