-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update demo to take account of play() being async #70
base: main
Are you sure you want to change the base?
Conversation
@@ -96,7 +96,7 @@ <h1>Video Conferencing App</h1> | |||
if (await MaybeStartCapturing()) { | |||
video.pause(); | |||
await track.cropTo(cropTargets[source]); | |||
video.play(); | |||
await video.play(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since OnSourceSelected()
is not called asynchronously which difference does it make?
@@ -106,7 +106,7 @@ <h1>Video Conferencing App</h1> | |||
video.style = "border: none; width: 500px; height: 500px;"; | |||
video.pause(); | |||
await track.cropTo(null); | |||
video.play(); | |||
await video.play(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for OnUncroppedSelected()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once comments are answered
No description provided.