Wagtail deprecated request.site #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the log says "Please update your code to use Site.find_for_request(request) in place of request.site."
Andreew4x4
approved these changes
Sep 11, 2020
|
I think you forgot to import the Site object, could you please take a look? |
|
Thanks for taking the effort to create a PR for this. As we're also taking backwards compatibility into account we made a release this week which applies these changes, as well as having it compatible with codebases that still have the SiteMiddleware implemented until Wagtail 2.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the log says "Please update your code to use Site.find_for_request(request) in place of request.site."
I'm making this change because I had to create my own middleware inside my app to get wagtailtrans running. this will fix the issues and have support for the future Wagtail versions.
related: Issue #185