-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodules to work with GCC 10 #67
base: jhess
Are you sure you want to change the base?
Conversation
We can't use Heng Li's latest, since Jeremiah made some changes to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Julian, I appreciate the help with this -- don't we still need the htslib submodule here though?
I made this PR against the |
Hi Julian -- so I'm looking back and I think I had made some of these submodule changes above that you suggested, but on the "cmake" branch. Do you use that branch or have capacity to see if that works on your system / fixes theses issues? |
I have not yet used that branch, but would be happy to switch over. Your message is really apropos; I'm actually hacking on a tool that uses SeqLib right now. |
That would be great if you could try it and see if that works, then I can
just move it over the main. I haven't built my own tool with SeqLib in a
while, you're the world expert on this now!
…On Tue, Jan 30, 2024 at 8:50 PM julianhess ***@***.***> wrote:
I have not yet used that branch, but would be happy to switch over. Your
message is really apropos; I'm actually hacking on a tool that uses SeqLib
right now.
—
Reply to this email directly, view it on GitHub
<#67 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUZ7CAJGXJQHULLZZ2JVN3YRGPNNAVCNFSM6AAAAAATACF3JWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJYGIYTQMRVGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Fixes #66