Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodules to work with GCC 10 #67

Open
wants to merge 6 commits into
base: jhess
Choose a base branch
from

Conversation

julianhess
Copy link
Contributor

Fixes #66

Copy link
Owner

@walaj walaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Julian, I appreciate the help with this -- don't we still need the htslib submodule here though?

@julianhess
Copy link
Contributor Author

I made this PR against the jhess branch (PR'd here: #64), which uses the system htslib, rather than embedding it as a submodule. (I still have to update the tests to get that one merged 😬).

@walaj
Copy link
Owner

walaj commented Jan 31, 2024

Hi Julian -- so I'm looking back and I think I had made some of these submodule changes above that you suggested, but on the "cmake" branch. Do you use that branch or have capacity to see if that works on your system / fixes theses issues?

@julianhess
Copy link
Contributor Author

I have not yet used that branch, but would be happy to switch over. Your message is really apropos; I'm actually hacking on a tool that uses SeqLib right now.

@walaj
Copy link
Owner

walaj commented Jan 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants