[Bug]: 其他页面 pageview 异常 || [Bug]: Pageview exception on other pages #2207

BeiyanYunyi · 2023-12-19T16:47:09Z

问题描述 | Describe the bug

复现版本为 master 分支 6c9f4f6 。后端与 https://waline.js.org/ 相同。

复现方法为，将 pnpm client:dev 的 http://localhost:5173/pageview.html 改为如下所示：

<!doctype html>
<html>
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Waline pageview test</title>
  </head>
  <body>
    阅读量: <span id="/" class="waline-pageview-count"></span>
    页面阅读量 1：
    <span
      class="waline-pageview-count"
      data-path="/guide/features/pageview.html"
    ></span
    >页面阅读量 2：<span
      class="waline-pageview-count"
      data-path="/guide/features/i18n.html"
    ></span>
    <script type="module">
      import { pageviewCount } from '../src/entries/pageview.ts';

      pageviewCount({
        serverURL:
          import.meta.env.SERVERURL || 'https://walinejs.comment.lithub.cc',
        path: '/',
      });
    </script>
  </body>
</html>

即可见“页面阅读量 1”与“页面阅读量 2”处出现异常。出现异常的原因是在查询其他页面的访问量时，服务端返回值与客户端预期不同。

BeiyanYunyi/sodesu@8208fae 在前端给出了一个可能的缓解或修复措施。然而，我认为服务端的接口同样需要统一。

问题网站 | Website URL

https://waline.js.org/

服务部署在哪里？ | Where your waline deploy?

Vercel (Default)

数据存储在哪里？| Where your comment data store?

LeanCloud(https://leancloud.app)

Problem description | Describe the bug

The reproducible version is master branch 6c9f4f6. The backend is the same as https://waline.js.org/.

The method to reproduce is to change http://localhost:5173/pageview.html of pnpm client:dev to the following:

<!doctype html>
<html>
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Waline pageview test</title>
  </head>
  <body>
    Reading volume: <span id="/" class="waline-pageview-count"></span>
    Page views 1:
    <span
      class="waline-pageview-count"
      data-path="/guide/features/pageview.html"
    ></span
    >Page views 2:<span
      class="waline-pageview-count"
      data-path="/guide/features/i18n.html"
    ></span>
    <script type="module">
      import { pageviewCount } from '../src/entries/pageview.ts';

      pageviewCount({
        serverURL:
          import.meta.env.SERVERURL || 'https://walinejs.comment.lithub.cc',
        path: '/',
      });
    </script>
  </body>
</html>

It can be seen that there are exceptions at "Page Views 1" and "Page Views 2". The reason for the exception is that when querying the visits of other pages, the server return value is different from the client's expectation.

BeiyanYunyi/sodesu@8208fae gives a possible mitigation or fix on the front end. However, I think the server-side interface also needs to be unified.

Question Website | Website URL

https://waline.js.org/

Where is the service deployed? | Where your waline deploy?

Vercel (Default)

Where is the data stored? | Where your comment data store?

LeanCloud(https://leancloud.app)

The text was updated successfully, but these errors were encountered:

lizheming · 2023-12-20T04:43:09Z

pageview 接口之前是有一个返回数据问题，是当请求一条的时候返回的是 1，而多条的时候返回的是 [1,1] 数组格式。这块在新的版本中已经都统一成了 {errmsg: '', errno: '', data: [1]} 结构体了。前提是需要使用 <serverURL>/api 新的接口来请求。
我看了下你的 MR BeiyanYunyi/sodesu@8208fae 没有看太明白，我们应该是不会返回{time: 1} 这种结构的。这块建议你直接发下请求地址我一块看看。

The pageview interface had a problem with returning data before. When one request was made, it returned 1, and when multiple requests were made, it returned the [1,1] array format. This has been unified into the {errmsg: '', errno: '', data: [1]} structure in the new version. The premise is that you need to use the <serverURL>/api new interface to request.
I took a look at your MR BeiyanYunyi/sodesu@8208fae. I didn’t understand it very well. We should not return a structure like {time: 1}. It is recommended that you directly send the request address and I will take a look.

BeiyanYunyi · 2023-12-20T06:08:59Z

对于“其他页面 pageview”的情况：

GET https://walinejs.comment.lithub.cc/api/article?path=/guide/features/pageview.html,/guide/features/i18n.html&type=time&lang=zh-CN

返回值：

{"errno":0,"errmsg":"","data":[{"time":5995},{"time":4844}]}

对于“本页面 pageview”的情况：

POST https://walinejs.comment.lithub.cc/api/article?lang=zh-CN

返回值：

{"errno":0,"errmsg":"","data":[125849]}

两个返回值的 data 格式很显然是不同的。

For the case of "other page pageview":

GET https://walinejs.comment.lithub.cc/api/article?path=/guide/features/pageview.html,/guide/features/i18n.html&type=time&lang=zh-CN

return value:

{"errno":0,"errmsg":"","data":[{"time":5995},{"time":4844}]}

For the case of "this page pageview":

POST https://walinejs.comment.lithub.cc/api/article?lang=zh-CN

return value:

{"errno":0,"errmsg":"","data":[125849]}

The data format of the two return values is obviously different.

Mister-Hope · 2024-01-07T15:11:52Z

Any update with this @lizheming, dpes client side code need any changes?

Mister-Hope · 2024-02-16T09:52:49Z

@lizheming 我这两天又羊了，正难受，你看一下这个问题是 @waline/api 写的有问题还是的确需要 refine 一下服务端的 api 吧。

@lizheming I've been having trouble these past two days and I'm feeling uncomfortable. Please check if this question is written by @waline/api, or if the server-side API really needs to be refined.

lizheming · 2024-02-16T14:03:26Z

@Mister-Hope 是服务端 API 改造的问题，这个我正在纠结预期的返回格式是什么样子的，确认完之后再统一修改一下。

@Mister-Hope It’s a question of server-side API transformation. I’m struggling with what the expected return format should be. I’ll make unified changes after confirmation.

lizheming · 2024-02-17T03:41:58Z

为了统一 pageview 和 reaction 的返回格式，思考了下，最终统一按照如下结构体进行统一返回。@waline/client@v3 也需要进行下适配，这块我来同步修改一下。

type ResponseData = Counter[];

interface Counter {
  time?: number;
  reaction0: number;
  reaction1: number;
}

In order to unify the return format of pageview and reaction, I thought about it and finally unified the return according to the following structure. @waline/client@v3 also needs to be adapted. I will modify this synchronously.

type ResponseData = Counter[];

interface Counter {
  time?: number;
  reaction0: number;
  reaction1: number;
}

FidStyle · 2024-02-20T05:04:06Z

按照文档配置发生error，仍然无法显示
服务端客户端均为latest
@lizheming

lizheming · 2024-02-20T15:02:42Z

@FidStyle 修了，更新到 @waline/[email protected] 吧

@FidStyle fixed it and updated it to @waline/[email protected]

BeiyanYunyi added the bug Something isn't working label Dec 19, 2023

github-actions bot changed the title ~~[Bug]: 其他页面 pageview 异常~~ [Bug]: 其他页面 pageview 异常 || [Bug]: Pageview exception on other pages Dec 19, 2023

lizheming removed the bug Something isn't working label Dec 20, 2023

lizheming added the Needs more info Further information is needed label Dec 20, 2023

lizheming added bug Something isn't working and removed Needs more info Further information is needed labels Dec 20, 2023

lizheming self-assigned this Dec 20, 2023

github-actions bot added the Inactive label Feb 16, 2024

lizheming mentioned this issue Feb 16, 2024

[Bug]: 阅读次数显示[object Object] || [Bug]: Reading count display [object Object] #2335

Closed

FidStyle mentioned this issue Feb 16, 2024

0.4.1部分问题：waline显示异常 & video标签无法显示 theme-shoka-x/hexo-theme-shokaX#236

Closed

5 tasks

lizheming mentioned this issue Feb 17, 2024

[fix] pageview api struct refactor #2343

Merged

Mister-Hope closed this as completed in #2343 Feb 19, 2024

lizheming added a commit that referenced this issue Feb 20, 2024

fix: fix #2207 undefined property read error

a475808

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: 其他页面 pageview 异常 || [Bug]: Pageview exception on other pages #2207

[Bug]: 其他页面 pageview 异常 || [Bug]: Pageview exception on other pages #2207

BeiyanYunyi commented Dec 19, 2023 •

edited by github-actions bot

Loading

lizheming commented Dec 20, 2023 •

edited by github-actions bot

Loading

BeiyanYunyi commented Dec 20, 2023 •

edited by github-actions bot

Loading

Mister-Hope commented Jan 7, 2024

Mister-Hope commented Feb 16, 2024 •

edited by github-actions bot

Loading

lizheming commented Feb 16, 2024 •

edited by github-actions bot

Loading

lizheming commented Feb 17, 2024 •

edited by github-actions bot

Loading

FidStyle commented Feb 20, 2024

lizheming commented Feb 20, 2024 •

edited by github-actions bot

Loading

[Bug]: 其他页面 pageview 异常 || [Bug]: Pageview exception on other pages #2207

[Bug]: 其他页面 pageview 异常 || [Bug]: Pageview exception on other pages #2207

Comments

BeiyanYunyi commented Dec 19, 2023 • edited by github-actions bot Loading

问题描述 | Describe the bug

问题网站 | Website URL

服务部署在哪里？ | Where your waline deploy?

数据存储在哪里？| Where your comment data store?

Problem description | Describe the bug

Question Website | Website URL

Where is the service deployed? | Where your waline deploy?

Where is the data stored? | Where your comment data store?

lizheming commented Dec 20, 2023 • edited by github-actions bot Loading

BeiyanYunyi commented Dec 20, 2023 • edited by github-actions bot Loading

Mister-Hope commented Jan 7, 2024

Mister-Hope commented Feb 16, 2024 • edited by github-actions bot Loading

lizheming commented Feb 16, 2024 • edited by github-actions bot Loading

lizheming commented Feb 17, 2024 • edited by github-actions bot Loading

FidStyle commented Feb 20, 2024

lizheming commented Feb 20, 2024 • edited by github-actions bot Loading

BeiyanYunyi commented Dec 19, 2023 •

edited by github-actions bot

Loading

lizheming commented Dec 20, 2023 •

edited by github-actions bot

Loading

BeiyanYunyi commented Dec 20, 2023 •

edited by github-actions bot

Loading

Mister-Hope commented Feb 16, 2024 •

edited by github-actions bot

Loading

lizheming commented Feb 16, 2024 •

edited by github-actions bot

Loading

lizheming commented Feb 17, 2024 •

edited by github-actions bot

Loading

lizheming commented Feb 20, 2024 •

edited by github-actions bot

Loading