Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to show/hide RSS button #34

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

oliverhihn
Copy link
Contributor

Added the option to hide the RSS feed button by setting SHOW_RSS_BUTTON=0. To show the button, it has to be set 1.

@waschinski
Copy link
Owner

waschinski commented Jul 14, 2022

Hey thanks for requesting and submitting the PR for #33 :)

Would you mind slightly renaming the setting though? None of the other options that show or hide a button have button in the name so I think SHOW_RSS_FEED would be more in line with the existing naming scheme. What do you think?

Oh and one more small thing: the default value should probably be 1 instead of 0 in order to not mess up instances of existing users when upgrading.

CHanged default value to 1 to show the button by default
@oliverhihn
Copy link
Contributor Author

Done! Yes you are right about the name schema. And I also changed the default value to 1.

@waschinski waschinski merged commit e67efd7 into waschinski:master Jul 14, 2022
@waschinski
Copy link
Owner

Thank you very much!

@oliverhihn
Copy link
Contributor Author

You welcome! Thank you, for this awesome application!

@waschinski waschinski mentioned this pull request Jul 19, 2022
pull bot pushed a commit to OrangeCatSleepless/photo-stream that referenced this pull request Mar 18, 2023
Added option to show/hide RSS button waschinski#33 

Former-commit-id: e67efd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants