Add option to reverse image sort by default #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the images where sorted based on when they were taken from newest to oldest image. This is not alway the wished behaviour as discussed in waschinski#42. Therefore this commit will add a new option in the .env file which when set will reverse the images upon assignment
|
I tried this, works well for me! Thanks for thinking up a better solution, this indeed works better since no reversing is done after loading. |
|
Thank you for the PR, Markus! A new release including it will probably have to wait until I am back from vacation though. |
Closed
pull bot
pushed a commit
to OrangeCatSleepless/photo-stream
that referenced
this pull request
Mar 18, 2023
…default Add option to reverse image sort by default Former-commit-id: b4a41dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all thank you for this project, I really like the minimal approach of the gallery which take away the need for a bloated backend, user management or database. I just started using the project and stumbled upon the exact issue mentioned in Issue #42. The proposed JS "hack" worked kinda wonky for me and at least in Safari I had some quick sort-changes during loading the page and it did not always end up in the correct sort order I intended. Therefore I would like to propose the change in this MR.
This MR will add a new variable in the
.envfile calledDEFAULT_REVERSE_SORTwhich when set to 1 will add the liquid reverse filter to the images array assignment inside theindex.html. This allows the templates to stay clean of any filters, keeping the logic in the index file without the need to change the JavaScript which might behave different for each browser.This change was tested with both variable values set using the docker-compose file building locally and it worked at least on my machine as intended.
Let me know if you see any improvements which can be done to that approach or if you want any other variable naming.