Revert "[LCP] Add animated image support" #31398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b7d510c06e0436cfb4bd7260175cd460b949225c. Reason for revert: speculative revert for new flakiness in PageLoadMetricsBrowserTestWithAnimatedLCPFlag, see first failing build https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/99853 Original change's description: > [LCP] Add animated image support > > This CL adds support for better handling of animated images in LCP: > * A new attribute is exposing the first animated frame's paint time > (behind a flag). > * `startTime` is not changed. > * The PageLoadMetrics reported for LCP are set to that first frame paint > time for animated images (behind another flag). > * Entries are not emitted until the image is loaded. > > Relevant spec issue: > w3c/largest-contentful-paint#83 > > Change-Id: I6bb01eacb4f200f9c032ffcfcd9a1a41126a7773 > Bug: 1260953 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226157 > Commit-Queue: Yoav Weiss <[email protected]> > Reviewed-by: Nicolás Peña Moreno <[email protected]> > Cr-Commit-Position: refs/heads/main@{#935133} Bug: 1260953 Change-Id: I00878689de95de38645195da81c6baf577d868a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247071 Auto-Submit: Mikel Astiz <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Mikel Astiz <[email protected]> Owners-Override: Mikel Astiz <[email protected]> Cr-Commit-Position: refs/heads/main@{#935350}
wpt-pr-bot
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b7d510c06e0436cfb4bd7260175cd460b949225c.
Reason for revert: speculative revert for new flakiness in
PageLoadMetricsBrowserTestWithAnimatedLCPFlag, see first failing
build
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/99853
Original change's description:
Bug: 1260953
Change-Id: I00878689de95de38645195da81c6baf577d868a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247071
Auto-Submit: Mikel Astiz <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Owners-Override: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#935350}