AnonymousIframe: WPT BroadcastChannel #2

[chromium-wpt-export-bot]

The previous patch:
https://chromium-review.googlesource.com/c/chromium/src/+/3371612/6
checked an AnonymousIframe and an Iframe wasn't sharing the same
partition.

This one test:

• Two sibling same-origin anonymous iframe share the same partition.
• Two same-origin nested anonymous iframe share the same partition.
• Two same-origin anonymous iframe from different popup do not share
  the same partition.

Bug: 1285331,1226469
Change-Id: I7ebc3a5bbb5e1f12d0ceaac9d89c1deb30174a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3379159
Reviewed-by: Andrew Williams <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#960946}

[wpt-pr-bot]

The review process for this patch is being conducted in the Chromium project.

[WeizhongX]

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test	Subtest	Results	Messages
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html		OK: 8/10, TIMEOUT: 2/10
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html	Anonymous iframe and normal iframe aren't in the same partition	FAIL: 8/10, MISSING: 2/10	assert_unreached: BroadcastChannel shouldn't cross the anonymous/normal border Reached unreachable code
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html	Two sibling same-origin anonymous iframes are in the same partition	PASS: 8/10, MISSING: 2/10
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html	Nested same-origin anonymous iframe are in the same partition	PASS: 8/10, MISSING: 2/10
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html	Two anonymous iframes in different windows do not share the same partition	PASS: 8/10, MISSING: 2/10

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

[WeizhongX]

created crbug/1288906. @past can you help admin merge?

[ArthurSonzogni]

Sorry about this. It seems to be a problem with Firefox. I believe it was a pre-existing problem, because I have an other patch adding new functions to common.js causing this one to fail

I can't do much. So I believe I will make a patch removing one of the test case, disable it for Firefox, or move it to wpt_internal instead.

edit: I will push: https://chromium-review.googlesource.com/c/chromium/src/+/3401863/

[past]

Merged, thanks!