Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event-timing-test-utils.js tap() has some unknown flaky memory leak issue related to test_driver.Actions(), while test_driver also has a built in function for click which doesn't cause any memory leak.
This commit replace tap with click to fix the memory leak and re-enable
the disabled test.
Test coverage for tap will be added later once Bug 1338420 is fixed.
Also added helper function addListenersAndClick() to reduce repetitive
patterns between tests.
Bug: 1335002
Change-Id: Ic2670288e596ff5eac8f1e742e395717bdabde5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747288
Reviewed-by: Lan Wei <[email protected]>
Commit-Queue: Aoyuan Zuo <[email protected]>
Reviewed-by: Michal Mocny <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1021762}