Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wdspec] browsingContext.print: fix rounding error in page.py test #40504

Merged
merged 5 commits into from
Jun 16, 2023
Merged

[wdspec] browsingContext.print: fix rounding error in page.py test #40504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f20a9d5
[wdspec] browsingContext.print: fix rounding error in page.py test
thiagowfx Jun 12, 2023
7e65d91
use floor in cm_to_px instead of round
thiagowfx Jun 13, 2023
63f894e
compare to floor and to round instead of a range
thiagowfx Jun 13, 2023
d2f73a9
Revert "compare to floor and to round instead of a range"
thiagowfx Jun 14, 2023
f00a6e1
Revert "use floor in cm_to_px instead of round"
thiagowfx Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tools/wptrunner/wptrunner/print_pdf_runner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@
let loadingTask = pdfjsLib.getDocument({data: atob(pdfData)});
let pdf = await loadingTask.promise;
let rendered = [];
for (let pageNumber=1; pageNumber<=pdf.numPages; pageNumber++) {
for (let pageNumber = 1; pageNumber <= pdf.numPages; pageNumber++) {
let page = await pdf.getPage(pageNumber);
var viewport = page.getViewport({scale: 96./72.});
const viewport = page.getViewport({ scale: 96. / 72. });
// Prepare canvas using PDF page dimensions
var canvas = document.getElementsByTagName('canvas')[0];
var context = canvas.getContext('2d');
const canvas = document.getElementsByTagName('canvas')[0];
const context = canvas.getContext('2d');
canvas.height = viewport.height;
canvas.width = viewport.width;

// Render PDF page into canvas context
var renderContext = {
const renderContext = {
canvasContext: context,
viewport: viewport
viewport
};
await page.render(renderContext).promise;
rendered.push(canvas.toDataURL());
Expand Down
4 changes: 2 additions & 2 deletions webdriver/tests/support/fixtures_bidi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ async def assert_pdf_dimensions(pdf, expected_dimensions):
png = await render_pdf_to_png_bidi(pdf)
width, height = png_dimensions(png)

assert cm_to_px(expected_dimensions["height"]) == height
assert cm_to_px(expected_dimensions["width"]) == width
assert (height - 1) <= cm_to_px(expected_dimensions["height"]) <= (height + 1)
thiagowfx marked this conversation as resolved.
Show resolved Hide resolved
assert (width - 1) <= cm_to_px(expected_dimensions["width"]) <= (width + 1)

return assert_pdf_dimensions

Expand Down
Loading