Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing if detectMarker is necessary #362

Merged
merged 10 commits into from
Jan 5, 2024
Merged

Testing if detectMarker is necessary #362

merged 10 commits into from
Jan 5, 2024

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Dec 19, 2023

For more infos go to issue #361

List of features:

@kalwalt kalwalt added enhancement New feature or request C/C++ emscripten dependencies Pull requests that update a dependency file Typescript labels Dec 19, 2023
@kalwalt kalwalt self-assigned this Dec 19, 2023
@kalwalt kalwalt changed the base branch from master to dev December 19, 2023 18:30
@kalwalt
Copy link
Member Author

kalwalt commented Dec 20, 2023

I can't build the build libs with emsdk 3.1.50, i will open a separate issue for that, for now i will try with an older version but major of 3.1.32

@kalwalt
Copy link
Member Author

kalwalt commented Dec 20, 2023

I can't build the build libs with emsdk 3.1.50, i will open a separate issue for that, for now i will try with an older version but major of 3.1.32

The libs can be build with emsdk 3.1.40 the only issue that we have now: the log message from ARLOG's print in the console.error message (intead of console.warning, this change was done in version 3.1.39 ), i will change this behaviour.

@kalwalt
Copy link
Member Author

kalwalt commented Jan 4, 2024

I think it is almost ready, will be merged when PR webarkit/WebARKitLib#26 is done.

@kalwalt kalwalt merged commit 32d130b into dev Jan 5, 2024
3 checks passed
@kalwalt kalwalt deleted the check-detectMarker branch January 5, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C/C++ dependencies Pull requests that update a dependency file emscripten enhancement New feature or request Typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant