Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Solve issue #11 #16

Merged
merged 3 commits into from
May 2, 2023
Merged

Test: Solve issue #11 #16

merged 3 commits into from
May 2, 2023

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented May 1, 2023

I will try to solve the issue #11. This is necessary because it's a show stopper for the project.
Probably, as ttated in the mentioned issue, it is required a code resyling of the WebARKitTracker's classes. I Will report here my findings.

Additional changes:

  • clang-format file to format C++ code

- move track method back to WebARKitTracker class
- removing not necessary classes
- fix issue #11
@kalwalt kalwalt added bug Something isn't working enhancement New feature or request Emscripten / C / C++ all about Emscripten labels May 1, 2023
@kalwalt
Copy link
Member Author

kalwalt commented May 2, 2023

It seems that commit d502a04 and 9cc0ee2 solved the issue.
I will merge this PR as it was intended only to fix #11

@kalwalt kalwalt merged commit 29a33f3 into main May 2, 2023
@kalwalt kalwalt deleted the solve--issue-#11 branch May 3, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Emscripten / C / C++ all about Emscripten enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant