This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Upgrade to istanbul-lib-instrument #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
|
|
||
| module.exports = function(source) { | ||
| module.exports = function(source, sourceMap, done) { | ||
| var userOptions = loaderUtils.parseQuery(this.query); |
There was a problem hiding this comment.
... right, my fault!
MichaReiser
force-pushed
the
istanbul-lib-instrument
branch
from
5769735
to
4714587
Compare
MichaReiser
force-pushed
the
istanbul-lib-instrument
branch
from
4714587
to
cb44c62
Compare
|
so should we wait for istanbuljs-archived-repos/istanbul-lib-instrument#23 first? I'm ready to merge this and bump new major version. |
|
I would wait some days in the hope that they accept the change. If not, then I will split the change into two pull requests. Thx for your fast responses! |
|
please split this into 2 PRs 👍 |
MichaReiser
force-pushed
the
istanbul-lib-instrument
branch
from
cb44c62
to
1d0356b
Compare
|
I removed the source map support from this branch. Second pull request follows tomorrow.... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade loader to use istanbul-lib-instrument to be future prove.
It also adds support for ES6, so the isparta loader is not needed anymore