-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop node version 12 #3251
Conversation
Codecov Report
@@ Coverage Diff @@
## next #3251 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 23 23
Lines 1731 1731
Branches 519 519
=======================================
Hits 1594 1594
Misses 137 137 Continue to review full report at Codecov.
|
I suppose we should point it to the |
I don't think so as |
That branch is indeed far behind. Then, should we do a release before merging this PR to master? WDYT @alexander-akait |
I think |
PR was closed because I rename So let's start the new |
On it 👍🏽 |
Let's also not merge any more PRs to master, to avoid rebasing. |
@snitin315 I think merging deps will not be a problem, rebasing it not hard here, but other PRs - yes |
What kind of change does this PR introduce?
chore.
Drop node v12 as suggested by @alexander-akait
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
Nope
Summary
Does this PR introduce a breaking change?
Other information
#3243 (comment)