Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop node version 12 #3251

Merged
merged 3 commits into from
May 20, 2022
Merged

chore: drop node version 12 #3251

merged 3 commits into from
May 20, 2022

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
chore.
Drop node v12 as suggested by @alexander-akait

Did you add tests for your changes?
Nope

If relevant, did you update the documentation?
Nope

Summary

Does this PR introduce a breaking change?

Other information

#3243 (comment)

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #3251 (03ee3ab) into next (e6f6e25) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #3251   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files          23       23           
  Lines        1731     1731           
  Branches      519      519           
=======================================
  Hits         1594     1594           
  Misses        137      137           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f6e25...03ee3ab. Read the comment docs.

@rishabh3112 rishabh3112 marked this pull request as ready for review May 17, 2022 08:24
@rishabh3112 rishabh3112 requested a review from a team as a code owner May 17, 2022 08:24
@snitin315
Copy link
Member

snitin315 commented May 17, 2022

I suppose we should point it to the next branch.

@rishabh3112
Copy link
Member Author

I suppose we should point it to the next branch.

I don't think so as next branch is pretty outdated to qualify for a major release (290+ commits behind).
Also, as per @alexander-akait 's comment above, we need a major release now asap. So, master should be the location.

@snitin315
Copy link
Member

That branch is indeed far behind. Then, should we do a release before merging this PR to master? WDYT @alexander-akait

package.json Outdated Show resolved Hide resolved
evenstensberg
evenstensberg previously approved these changes May 17, 2022
package.json Outdated Show resolved Hide resolved
@alexander-akait
Copy link
Member

I think next is outdated, but there is simple list of improvements #2879, so I think we can start new branch next (rename old next to next-old), move already done work to new next + solve TODOs from list, here little bit more work for us

@alexander-akait
Copy link
Member

PR was closed because I rename next to next-old, I will not remove branch because we need to move code here.

So let's start the new next and merge it in next

@rishabh3112
Copy link
Member Author

I think next is outdated, but there is simple list of improvements #2879, so I think we can start new branch next (rename old next to next-old), move already done work to new next + solve TODOs from list, here little bit more work for us

On it 👍🏽

@snitin315 snitin315 changed the base branch from master to next May 19, 2022 03:06
@snitin315
Copy link
Member

Let's also not merge any more PRs to master, to avoid rebasing.

@alexander-akait
Copy link
Member

@snitin315 I think merging deps will not be a problem, rebasing it not hard here, but other PRs - yes

@alexander-akait alexander-akait merged commit e60b5a3 into next May 20, 2022
@alexander-akait alexander-akait deleted the chore/drop-node-12 branch May 20, 2022 09:59
snitin315 pushed a commit that referenced this pull request Jun 11, 2022
snitin315 pushed a commit that referenced this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants