Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop webpack v4 from tests, packages, and CI #3338

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jul 18, 2022

What kind of change does this PR introduce?
refactor

Did you add tests for your changes?
Removed tests for webpack 4.

If relevant, did you update the documentation?
No.

Summary

Drop webpack v4 from tests, packages, and CI.

Does this PR introduce a breaking change?
Yes.

Other information
Yes.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #3338 (bc7788a) into next (76a8e3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #3338   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files          22       22           
  Lines        1713     1713           
  Branches      511      511           
=======================================
  Hits         1578     1578           
  Misses        135      135           
Impacted Files Coverage Δ
packages/serve/src/index.ts 82.03% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a8e3d...bc7788a. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@snitin315 snitin315 marked this pull request as ready for review July 18, 2022 17:20
@snitin315 snitin315 requested a review from a team as a code owner July 18, 2022 17:20
@snitin315 snitin315 merged commit df4feea into next Jul 18, 2022
@snitin315 snitin315 deleted the drop-webpack-4 branch July 18, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants