Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add CLA link #3461

Merged
merged 1 commit into from
Oct 24, 2022
Merged

docs: add CLA link #3461

merged 1 commit into from
Oct 24, 2022

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Oct 23, 2022

What kind of change does this PR introduce?
docs.

Did you add tests for your changes?
No.

If relevant, did you update the documentation?
Yes.

Summary

Add CLA Link

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner October 23, 2022 01:18
@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #3461 (d393d20) into next (1d362d4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #3461   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          22       22           
  Lines        1587     1587           
  Branches      447      447           
=======================================
  Hits         1449     1449           
  Misses        138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d362d4...d393d20. Read the comment docs.

@@ -236,7 +236,7 @@ docs: update README.md

## Contributor License Agreement

When submitting your contribution, a CLA (Contributor License Agreement) bot will come by to verify that you signed the CLA. If you are submitting a PR for the first time, it will link you to the right place to sign it. If you have committed your contributions using an email that is not the same as your email used on GitHub, the CLA bot can't accept your contribution.
When submitting your contribution, a CLA (Contributor License Agreement) bot will come by to verify that you signed the [CLA](https://easycla.lfx.linuxfoundation.org/#/?version=2). If you are submitting a PR for the first time, it will link you to the right place to sign it. If you have committed your contributions using an email that is not the same as your email used on GitHub, the CLA bot can't accept your contribution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why v2 as queryparam?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it contains the better UI, not more, just for users

@alexander-akait alexander-akait merged commit 4bc3294 into next Oct 24, 2022
@alexander-akait alexander-akait deleted the fix-cla-link branch October 24, 2022 15:53
snitin315 added a commit that referenced this pull request Nov 6, 2022
snitin315 added a commit that referenced this pull request Nov 8, 2022
alexander-akait pushed a commit that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants