Feat: loader and plugin command [2] #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- break plopfile generator and action logic in generators and actions - loading them asynchronously - modularity reduces redundancy and increases scalability
…en template - change defaultValues and generator function to be based on --template flag - add fallback prompt when template is invalid or unsupported
…d of just file name
- change default to resemble the design pattern of react generator - simple conditional flow for file creation and manipulation
- unpacked size decreased from ~60kb to 19kb
- for better ux added emojis according to type of log
- introduce a directory structure of commandName/[template1, template2] - move default and react template generators in init/* - avoid namespace issues and cleaner structure
…es and generator imports
…ction - the factory function returns a variant of utils configured with the path passed as argument
snitin315
reviewed
Aug 21, 2024
| @@ -1,16 +1,16 @@ | |||
| import { WebpackCLILogger } from "webpack-cli"; | |||
| import { green, yellow, Color, red, cyan, cyanBright, blue, blueBright } from "colorette"; | |||
| import { PlopActionHooksChanges, PlopActionHooksFailures } from "../types"; | |||
| import { basename } from "path"; | |||
| import { relative } from "path"; | |||
|
|
|||
| const prefix: string = blueBright("create-webpack"); | |||
| const getLogger = (): WebpackCLILogger => { | |||
There was a problem hiding this comment.
Can't we use the logger like below?
import webpackCLI from "webpack-cli"
const cli = new webpackCLI();
cli.logger()There was a problem hiding this comment.
I think that I am using logger only and defining it is easier than importing the whole webpackCLI().
also earlier I tried doing it but was getting into a lot of dependency complexities.
So this method was easier.
There was a problem hiding this comment.
Also I told you last time that the issue was that webpack-cli doesnt exports cli, only definitions.
error| '"webpack-cli"' has no exported member named 'webpackCLI'. Did you mean 'IWebpackCLI'?There was a problem hiding this comment.
We should avoid code duplication wherever possible
snitin315
changed the title
Co-authored-by: Anshuman Verma <[email protected]>
snitin315
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information