-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate to streamx #96
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tested and working as expected in a build of WebTorrent when communicating between clients.
@mafintosh as you are one of the few people with admin rights here, any chance you could change the required workflow from node 16 to 18 as the 16 workflow no longer exists but is still required? I assume it would be done in https://github.com/organizations/webtorrent/settings/actions but I can't verify that as I don't have admin permissions, and we can't do anything about it |
🎉 This PR is included in version 4.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:
What changes did you make? (Give an overview)
Migrated to streamx.
Which issue (if any) does this pull request address?
webtorrent/webtorrent#1971
Is there anything you'd like reviewers to focus on?
Tests fail, and I'm not sure why, I don't know if its my fault, or if its something with the tests.
Streamx defers many actions onto the next microtask, which is why some synchronous actions might fail.