Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate to streamx #96

Merged
merged 3 commits into from
May 30, 2023
Merged

fix: migrate to streamx #96

merged 3 commits into from
May 30, 2023

Conversation

ThaUnknown
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:

What changes did you make? (Give an overview)
Migrated to streamx.
Which issue (if any) does this pull request address?
webtorrent/webtorrent#1971
Is there anything you'd like reviewers to focus on?
Tests fail, and I'm not sure why, I don't know if its my fault, or if its something with the tests.
Streamx defers many actions onto the next microtask, which is why some synchronous actions might fail.

@socket-security
Copy link

socket-security bot commented May 26, 2023 •
edited
Loading

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] None +2 mafintosh

🚮 Removed packages: [email protected]

@ThaUnknown ThaUnknown enabled auto-merge (squash) May 26, 2023 23:29
SilentBot1
SilentBot1 approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@SilentBot1 SilentBot1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested and working as expected in a build of WebTorrent when communicating between clients.

@ThaUnknown
Copy link
Member Author

ThaUnknown commented May 29, 2023 •
edited
Loading

@mafintosh as you are one of the few people with admin rights here, any chance you could change the required workflow from node 16 to 18 as the 16 workflow no longer exists but is still required?

I assume it would be done in https://github.com/organizations/webtorrent/settings/actions but I can't verify that as I don't have admin permissions, and we can't do anything about it

@ThaUnknown ThaUnknown merged commit 9b77f6c into webtorrent:master May 30, 2023
webtorrent-bot pushed a commit that referenced this pull request May 30, 2023
@semantic-release-bot
chore(release): 4.1.7
84cd42e 
## [4.1.7](v4.1.6...v4.1.7) (2023-05-30)

### Bug Fixes

* **deps:** update dependency streamx to ^2.13.2 ([#117](#117)) ([c09a7f6](c09a7f6))
* **deps:** update dependency uint8-util to ^2.1.9 ([#110](#110)) ([9d3733c](9d3733c))
* migrate to streamx ([#96](#96)) ([9b77f6c](9b77f6c))
@webtorrent-bot
Copy link

🎉 This PR is included in version 4.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilentBot1 SilentBot1 SilentBot1 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThaUnknown @webtorrent-bot @SilentBot1